[Freeciv-Dev] Re: (PR#9856) RFC: caravans advisor

["Jason Dorje Short" <jdorje@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=9856 >

Benoit Hudson wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=9856 >
> 
> Bitrot is fixed.  Meanwhile, I ended up adding logic for wonders.
> I intend to commit this set of files tomorrow.

I'm not sure which set you mean, but there are numerous
stylistic/pseudo-technical problems with the caravan.[ch] files.

1.  Compiling these requires changes to Makefile.am, but your patches
don't include any such changes.  I don't even know which directory
they're supposed to go in.

2.  You need the Freeciv header comment (copyright/licence/disclaimer)
to be added to each file.

3.  Don't use CVS keywords.  We don't use them anywhere else, and we
shouldn't start right before switching to svn.

4.  #include <config.h> from the .c file, not from the .h file.  See
CodingStyle.

-jason