[Freeciv-Dev] (PR#13137) ai "stats" aren't initialized

["Jason Dorje Short" <jdorje@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13137 >

Each city has an ai structure with a stats structure inside it.  This
tracks, among other things, the number of units by class.  However these
values are never initialized.  ai.stats.units[x] is always 0 (I think
most other fields of ai.stats is too).  This qualifies as a major AI bug
since it means all the carefully crafted AI logic is always bogus.

In fact from what I can see it's not really possible to initialize these
values since you can't easily tell what class a unit belongs to.  There
is no unittype->class field for instance.  You probably have to look at
some combination of move type and unit flags.

That said, unit class is probably not what we want to be looking at
here.  Eventually the unit classes should be ruleset definable so
references to specific types won't be possible.  In the meantime most
stats should probably be done by move type or by unit flags directly
(count the number of units with NUKE ability rather than looking at the
number of UCL_MISSILE units).

-jason