[Freeciv-Dev] (PR#12963) nation.ruleset has init_government

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12963 >

> [bretta - Fri May 13 18:04:35 2005]:
> 
> Which version of this patch was checked in?  I downloaded nation2.diff
> and manually applied it to see which patch broke freeciv for me (see 
the
> ticket on trade tooltips and display being broken).  However, in 
looking
> through webCVS, I noticed a change to packets_gen.c referring to this
> ticket.  However, in nation2.diff there is no patching of 
packets_gen.c.

This file (and all other *_gen* ones) are automatically generated.  The 
ones generated by the packet generator are kept in CVS because the 
packet generator is in python which is otherwise not required for 
compilation.  The generated parts are usually left out of patches 
however (rm */*_gen* before doing your patch).

>  See the following from webCVS:
> 
> Revision 1.120  - (view) (download) (annotate) - [select for diffs]
> Sat May 7 14:03:51 2005 UTC (6 days, 3 hours ago) by per
> Branch: MAIN
> Changes since 1.119: +128 -46 lines
> Diff to previous 1.119 (colored)
> 
> Adds a new nation ruleset define init_government, which sets the
> starting government of a nation. This is very useful for modpacks.
> Removes useless AI hints in nation rulesets, replacing them with the
> above and init_units (implemented earlier). See PR#12963.

It's possible some nations added afterwards are missing some fields.  
I've added a few new nations lately and tried to update their fields to 
match those expected in CVS (some of the nation rulesets are made for 
2.0).  It's possible I missed some.

I don't see how this could relate to any effects/reqs issues though.

-jason