[Freeciv-Dev] (PR#12974) transfer_units() still has problems...

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12974 >

> civserver: sanitycheck.c:187: real_sanity_check_city: Assertion
`unit_owner(punit) == pplayer' failed.

Program received signal SIGABRT, Aborted.
[Switching to Thread -1208334656 (LWP 7485)]
0x006287a2 in _dl_sysinfo_int80 () from /lib/ld-linux.so.2
(gdb) bt
#0  0x006287a2 in _dl_sysinfo_int80 () from /lib/ld-linux.so.2
#1  0x006697d5 in raise () from /lib/tls/libc.so.6
#2  0x0066b149 in abort () from /lib/tls/libc.so.6
#3  0x00662db1 in __assert_fail () from /lib/tls/libc.so.6
#4  0x08084c32 in real_sanity_check_city (pcity=0x8927698, file=0x813a7b4
"cityturn.c",    line=207) at sanitycheck.c:270
#5  0x08067000 in auto_arrange_workers (pcity=0x8927698) at cityturn.c:207
#6  0x0806606e in transfer_city (ptaker=0x81ecc5c, pcity=0x8927698,
kill_outside=-1,    transfer_unit_verbose=false, resolve_stack=false, 
raze=false) at
citytools.c:843
#7  0x0807c248 in civil_war (pplayer=0x81e0fa4) at plrhand.c:2220
#8  0x0805c20d in handle_unit_move_consequences (punit=0x89948f8,
src_tile=0xb7c93d88,    dst_tile=0xb7c92248) at unittools.c:2686

(gdb) p *pcity
$2 = {id = 1051, owner = 2, tile = 0xb7c86a08,

(gdb) p *(struct unit *)pcity->units_supported->list->head_link->dataptr
$9 = {type = 11, id = 1444, owner = 11, tile = 0xb7c86a08, homecity =
1051, moves_left = 0,

The city is now supporting a unit that it does not own. I cannot see how
that is possible, but I guess I need to look more carefully at this.

  - Per