[Freeciv-Dev] (PR#12838) RFC: new behavior of start command

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12838 >

When the game finally does start in the new system there is no
notification until nation selection begins.  Often this can take several
seconds since mapgen must be run.

This patch causes a notification to be sent out immediately.

-jason

Index: server/stdinhand.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/stdinhand.c,v
retrieving revision 1.396
diff -u -r1.396 stdinhand.c
--- server/stdinhand.c  20 Apr 2005 16:54:33 -0000      1.396
+++ server/stdinhand.c  26 Apr 2005 04:15:58 -0000
@@ -3668,7 +3668,6 @@
       return TRUE;
     } else {
       int started = 0, notstarted = 0;
-      const int percent_required = 100;
 
       /* Note this is called even if the player has pressed /start once
        * before.  This is a good thing given that no other code supports
@@ -3687,12 +3686,13 @@
          }
        }
       } players_iterate_end;
-      if (started * 100 < (started + notstarted) * percent_required) {
+      if (notstarted > 0) {
        notify_player(NULL, _("Waiting to start game: %d out of %d players "
                              "are ready to start."),
                      started, started + notstarted);
        return TRUE;
       }
+      notify_player(NULL, _("All players are ready; starting game."));
       start_game();
       return TRUE;
     }