Complete.Org: Mailing Lists: Archives: freeciv-dev: March 2005:
[Freeciv-Dev] Re: (PR#12567) client segfault in S2
Home

[Freeciv-Dev] Re: (PR#12567) client segfault in S2

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: chrisk@xxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#12567) client segfault in S2
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 20 Mar 2005 16:40:08 -0800
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12567 >

Christian Knoke wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=12567 >
> 
> 
> CVS 21 MAR 2005 S2 GTK2
> 
> Not reproducible. Savegame before crash available.

Can you send the savegame?  And, what tileset were you using?

This patch *might* fix it (at a very slight cost in speed).  The 
hard-coded limit on the number of sprites in a tile has always been a 
bit iffy.

-jason

Index: client/mapview_common.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/mapview_common.c,v
retrieving revision 1.151.2.19
diff -u -r1.151.2.19 mapview_common.c
--- client/mapview_common.c     1 Mar 2005 21:46:46 -0000       1.151.2.19
+++ client/mapview_common.c     21 Mar 2005 00:39:40 -0000
@@ -1501,7 +1501,7 @@
 void put_one_tile_iso(struct canvas *pcanvas, struct tile *ptile,
                      int canvas_x, int canvas_y, bool citymode)
 {
-  struct drawn_sprite tile_sprs[80];
+  struct drawn_sprite tile_sprs[200];
   int count = fill_sprite_array(tile_sprs, ptile,
                                get_drawable_unit(ptile, citymode),
                                ptile->city, citymode);

[Prev in Thread] Current Thread [Next in Thread]