[Freeciv-Dev] Re: (PR#12546) Divide handicaps to real handicaps and cheats

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12546 >

Per I. Mathisen wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=12546 >
> 
> On Sat, 19 Mar 2005, Marko Lindqvist wrote:
> 
>>Handicaps need cleanup.
>>
>>Currently some handicaps really are handicaps (relative to rules) and
>>some are cheats. It's not always clear if given 'handicap' is positive
>>or negative thing to have. For more self documenting code there should
>>be separate ai_handicap() and ai_cheat() functions.
>>Further, ai_handicap() currently returns TRUE for human players. For
>>some (current) handicaps this is ok, for some it's wrong. So sometimes
>>it's callers responsibility to check that human players are handled
>>correctly, sometimes caller can rely on ai_handicap() return value.
> 
> 
> I am thinking this should be done simultaneously or after adding player
> effects.

But we don't yet know how player effects will be done.  It is an ugly 
problem.

-jason