[Freeciv-Dev] (PR#12504) RFC: use of effects for terrain/special data

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12504 >

The terrain.ruleset has a lot of parameters that can be simulated with 
effects:

1.  Irrigation bonus (Food_Add_Tile + 1, irrigation req)
2.  Mining bonus (2 effects, one for hills and one without)
3.  Road bonus (Trade_Inc_Tile)
4.  River bonus (Trade_Add_Tile)
5.  Farmland bonus (this may already be done with effects?)
6.  Railroad bonus (Prod_Per_Tile)
7.  Pollution/fallout penalty (-50% XXX_Per_Tile)

Removing all these can clean up a lot of code at no extra cost in 
runtime.  The only problem is in the order they are applied.  Currently 
this is a carefully crafted ordering in city.c.  But with effects we 
have much less control over the ordering (there's still some control 
since there are 3 effect types).

Is this worthwhile?

-jason