Complete.Org: Mailing Lists: Archives: freeciv-dev: March 2005:
[Freeciv-Dev] Re: (PR#11336) [Patch] movetype.[ch]
Home

[Freeciv-Dev] Re: (PR#11336) [Patch] movetype.[ch]

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] Re: (PR#11336) [Patch] movetype.[ch]
From: "Marko Lindqvist" <marko.lindqvist@xxxxxxxxxxx>
Date: Sun, 13 Mar 2005 02:21:02 -0800
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11336 >


  Updated patch against current CVS.


Gregory Berkolaiko wrote:
> 
> Please consider the following:
> is_ground and is_air refer to the substance in/on which the movement is
> performed.
> is_sailing refers to the way the movement is done
> 
> So I think is_sea_unit is better (and shorter too!)

  No changes to this. I didn't want to touch all the places where 
is_sailing_unit() is called. It's easy to change later, if needed. 
Development in generalized move types will probably make 
is_sailing_unit() obsolete anyway.


  - ML

Attachment: movement_files-4.diff.gz
Description: GNU Zip compressed data


[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] Re: (PR#11336) [Patch] movetype.[ch], Marko Lindqvist <=