[Freeciv-Dev] (PR#12375) freeciv2-beta8 Compile error helpdata.c on IRIX

["Joerg Behrens" <behrens@xxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12375 >

Hello,

there are 2 small issues outthere when compiling the beta8 on IRIX 6.5.27.

To bypass and enable readline support i have added  '-lcurses' to the
LDFLAGS otherwise i get an unresolve symbol.

checking whether readline works at runtime... 1368850:./conftest: rld:
Error: unresolvable symbol in /usr/nekoware/lib/libreadline.so.4: tputs
1368850:./conftest: rld: Error: unresolvable symbol in
/usr/nekoware/lib/libreadline.so.4: tgetstr
1368850:./conftest: rld: Error: unresolvable symbol in
/usr/nekoware/lib/libreadline.so.4: tgetflag
1368850:./conftest: rld: Error: unresolvable symbol in
/usr/nekoware/lib/libreadline.so.4: tgetnum
1368850:./conftest: rld: Fatal Error: this executable has unresolvable
symbols
no
configure: error: Specified --with-readline but the
runtime test of readline failed.


The second one is in client/helpdata.c

diff -urN ../freeciv-2.0.0-beta8/client/helpdata.c ./client/helpdata.c
--- ../freeciv-2.0.0-beta8/client/helpdata.c    Montag, 07. Februar 2005
17:47:24
+++ ./client/helpdata.c Samstag, 26. Februar 2005 20:11:39
@@ -547,12 +547,12 @@
       char req_buf[1024] = "";
       int i;

-#define req_append(s)
\
-      (req_buf[0] != '\0'
\
-       ? my_snprintf(req_buf + strlen(req_buf),
\
-                    sizeof(req_buf) - strlen(req_buf),
\
-                    ", %s", (s))
\
-       : sz_strlcpy(req_buf, (s)))
+#define req_append(s)
\
+      if(req_buf[0] !=
'\0'){                                               \
+        my_snprintf(req_buf + strlen(req_buf),
\
+                     sizeof(req_buf) - strlen(req_buf),
\
+                     ", %s", (s));
\
+       }else{ sz_strlcpy(req_buf, (s));}

       if (b->tech_req != A_NONE) {
        req_append(get_tech_name(game.player_ptr, b->tech_req));

The patch can also be downloaded on
http://www.irixworld.net/irix/bilder/freeciv2/freeciv-2.0.0beta8_irix.patch

The game runs great even on the older sgi machines. Good work guys!

regards
Joerg