[Freeciv-Dev] Re: (PR#12360) AutoReply: specfile specifies out-of-range sprite

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12360 >

The default queue wrote:

> If the specfile specifies a location on the file for a sprite to be, and 
> that location is outside of the file, then the result isn't very good.
> 
> I don't know what the result is in 2.0.  In 2.0.99 the gtk2 client will 
> crash inside of crop sprite (thanks to pixbufs).
> 
> Any time this happens I'm sure it's unintentional.  For instance it 
> happens in explosions.spec in r-hires.  This patch catches the error in 
> tilespec.c, reports an error, and simply returns the sprite as NULL.
> 
> Written for 2.0.99 but it probably applies to 2.0 also.

Interestingly trident and isotrident both fail this test.  Their 
explode.unit_4 graphic is out-of-range just like r-hires's.  I wonder if 
this explains why some windows users get unexplained crashes during combat?

I will provide a separate patch to fix those tilesets.

-jason