[Freeciv-Dev] (PR#12189) inefficiency in switch_city_callback

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12189 >

THere is this code to find the "next" city:

   for (i = 0; i < size; i++) {
     if (pdialog->pcity == city_list_get(game.player_ptr->cities, i)) {
       break;
     }
   }

problem is city_list_get is Real Slow so this is O(n^2).  Could be a 
problem on huge maps.

-jason