[Freeciv-Dev] (PR#12038) overwriting of settings

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12038 >

When saving client options, inactive options will get overwritten.  This 
may not sound like a problem but it is fairly major, and if development 
continues toward AC-like compatibility will become quite a bit worse.

Consider:

- I open up freeciv 1.14 for a quick "old" game.  I save my options. 
Now all the new client options are overwritten, and when I restart in 
2.0 they're all reset.

- I open up freeciv 2.0 for a quick "stable" game.  I save my options.
Now all the new client options are overwritten, and when I restart in 
2.1.99 they're all reset.

- I open up my SMAC ruleset for a quick "AC" game.  I save my options. 
However these options include the configuration data for AC-style 
specialists not for civ2-style specialists.  So when I restart using a 
freeciv ruleset my cityrep settings (which normally shows elvises) have 
been reset.

All of these are problems in the current game.  The latter is the most 
annoying (it also happens when switching between 2.0 and 2.1.99).

This could be solved just by leaving the inactive entries in place. 
Instead the whole file is overwritten so any inactive entry will be lost.

-jason