[Freeciv-Dev] Re: (PR#12020) compile warnings cleanup

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12020 >

Brett Albertson wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=12020 >
> 
>>[jdorje - Fri Jan 28 00:15:40 2005]:
>>
>>I don't like using casts to avoid warnings.  The warnings are
>>(occasionally) there for a reason, and using the cast simply hides it
>>rather than fixing it.  Changing variable types is the better solution.
> 
> 
> There are a couple of casts, but most are changes in variable types. 
> For example:
> 
> -  unsigned char hostname[512];
> -  unsigned char port[256];
> -  unsigned char version[256];
> -  unsigned char players[256];
> -  unsigned char status[256];
> +  char hostname[512];
> +  char port[256];
> +  char version[256];
> +  char players[256];
> +  char status[256];

Yes.  I would take just those parts and leave the rest, but I don't know 
if that will break anything (though it works for me).

Will you make a patch that doesn't use casts but only fixes types?  Then 
we can look at the remaining problem places and figure out what the 
right fix is.

-jason