Complete.Org: Mailing Lists: Archives: freeciv-dev: January 2005:
[Freeciv-Dev] (PR#12020) compile warnings cleanup
Home

[Freeciv-Dev] (PR#12020) compile warnings cleanup

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] (PR#12020) compile warnings cleanup
From: "Brett Albertson" <brett.albertson@xxxxxxxxxxxx>
Date: Thu, 27 Jan 2005 18:22:55 -0800
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12020 >

> [jdorje - Fri Jan 28 00:15:40 2005]:
> 
> I don't like using casts to avoid warnings.  The warnings are
> (occasionally) there for a reason, and using the cast simply hides it
> rather than fixing it.  Changing variable types is the better solution.

There are a couple of casts, but most are changes in variable types. 
For example:

-  unsigned char hostname[512];
-  unsigned char port[256];
-  unsigned char version[256];
-  unsigned char players[256];
-  unsigned char status[256];
+  char hostname[512];
+  char port[256];
+  char version[256];
+  char players[256];
+  char status[256];


-- 
Brett Albertson




[Prev in Thread] Current Thread [Next in Thread]