[Freeciv-Dev] (PR#12017) observer start game, cvs head crash

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12017 >

Bug 1: You can start a game with only an observer as a player. I believe
this to be a bug.

Bug 2: In cvs head (only), if you do this, disconnect client, and /quit,
you will get this crash:

Program received signal SIGSEGV, Segmentation fault.
0x080bf609 in ruleset_cache_free () at effects.c:407
407             effect_list_iterate(plist, peffect) {
(gdb) bt
#0  0x080bf609 in ruleset_cache_free () at effects.c:407
#1  0x080529f2 in server_game_free () at srv_main.c:1906
#2  0x08050b15 in server_quit () at srv_main.c:790
#3  0x0805a8d4 in quit_game (caller=0x0, check=false) at stdinhand.c:3266
#4  0x0805b33a in handle_stdin_input (caller=0x0, str=0x976b8d0 "q",
    check=false) at stdinhand.c:3454
#5  0x080a03e0 in handle_readline_input_callback (line=0x976b8f8 "q")
    at sernet.c:178
#6  0x026b09b1 in rl_callback_read_char () from /usr/lib/libreadline.so.4
#7  0x080a14e7 in sniff_packets () at sernet.c:567
#8  0x08052377 in srv_loop () at srv_main.c:1693
#9  0x0805225b in srv_main () at srv_main.c:1650
#10 0x0804aac9 in main (argc=1, argv=0xfeef7574) at civserver.c:209

  - Per