[Freeciv-Dev] Re: (PR#9856) RFC: caravans advisor

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=9856 >

On Sun, 9 Jan 2005, Benoit Hudson wrote:
> > This does not look sane. After handle_unit_help_build_wonder() punit has
> > likely been freed.
>
> Fixed.

Nice.

> > You do not touch ai_choose_help_wonder(). What role does it play now?
> >
> > You do not check if the caravan might have died during goto. This is
> > necessary (autoattack, huts).
>
> The old code didn't do either of these, so I don't really have an
> answer for you.Why would it have worked before?  Was it buggy?

Yes. The chance of the manifesting itself here is low (once you have
caravans, most huts will be explored away), but this is still a bug. With
autoattack this will happen more often, too.

  - Per