[Freeciv-Dev] (PR#9856) RFC: caravans advisor

["Benoit Hudson" <bh@xxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=9856 >

> [per - Sun Jan 09 20:36:29 2005]:
>         handle_unit_help_build_wonder(pplayer, punit->id);
> -      }
> +      freelog(LOG_CARAVAN, "%s's caravan %d helped build wonder in %s",
> +          pplayer->name, punit->id, wonder_city->name);
> 
> This does not look sane. After handle_unit_help_build_wonder() punit has
> likely been freed.

Fixed.

> You do not touch ai_choose_help_wonder(). What role does it play now?
>
> You do not check if the caravan might have died during goto. This is
> necessary (autoattack, huts).

The old code didn't do either of these, so I don't really have an 
answer for you.  Why would it have worked before?  Was it buggy?

caravan_ai.diff
Description: Binary data