[Freeciv-Dev] Re: (PR#11058) pubserver diplomat crash in vnotify_conn_ex

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11058 >

On Wed, 17 Nov 2004, Gregory Berkolaiko wrote:
> improvement can be B_LAST, then the target is randomly selected and put
> into "target"; still some code uses improvement as if it is a valid impr_id
>
> Attached fix also fixes a maths mistake: to sabotage a specific impr,
> the probability is halved (according to the rules) but the code squared
> it instead.

I think this is mistaken: It should be half diplchance probability of
getting caught if you use the random pick, and normal probability if you
choose a specific target (=more difficult). So the original code is also
wrong.

And this use of diplchance is not described in the server help.

  - Per