[Freeciv-Dev] Re: (PR#11797) odd vote behavior

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11797 >

On Thu, Jan 06, 2005 at 05:09:36AM -0800, Per I. Mathisen wrote:
> 
>   if (caller == NULL || caller->player == NULL) {
>     cmd_reply(CMD_VOTE, caller, C_FAIL, _("This command is client only."));
>     return FALSE;

this is a strange reply... (client only?)

> And here is code that (double-)checks on resolution:
> 
>   for (i = 0; i < MAX_NUM_PLAYERS; i++) {
>     if (game.players[i].is_alive && game.players[i].is_connected) {
>       num_voters++;
>     } else {
>       /* Disqualify already given vote (eg if disconnected after voting) */
>       vote->votes_cast[i] = VOTE_NONE;
>     }
>   }

hmm, I don't know. This code is I think the culprit for why end vote
tallies don't add up. Why should a voter be disqualified if they disconenct
after voting?

-mike