Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2004:
[Freeciv-Dev] (PR#11415) generic_city_refresh(pcity, FALSE, ...) is very 		Home

[Freeciv-Dev] (PR#11415) generic_city_refresh(pcity, FALSE, ...) is very

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx, per@xxxxxxxxxxx
Subject: [Freeciv-Dev] (PR#11415) generic_city_refresh(pcity, FALSE, ...) is very dangerous
From: "Benoit Hudson" <bh@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 31 Dec 2004 13:19:14 -0800
Reply-to: bugs@xxxxxxxxxxx 
<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11415 >

> [bhudson - Fri Dec 31 20:52:31 2004]:
> Looks like your patch changes the behaviour.  Probably we should make
> one copy, store it in the cm_state, and restore it at the end.

Here's a patch.  Side-effect: it doesn't make a copy every apply, which should 
save time.  This 
"works for me" (in a savegame that exhibited the bug).

Attachment: cm-11415.diff
Description: Binary data

[Prev in Thread] Current Thread [Next in Thread]