[Freeciv-Dev] Re: (PR#11692) New fogging broken on 16-bit displays

["Christian Knoke" <chrisk@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11692 >

On Sat, Dec 25, 2004 at 02:05:34PM -0800, Robert Smith wrote:
> 
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=11692 >
> 
> The new fogging code produces some very odd results on my 16-bit
> display.  To be honest, I'm not entirely sure what the logic behind the
> current gode in fog_sprite is, but this:
> 
> guint8 red = ((pixel & ftile->visual->red_mask) >>
> ftile->visual->red_shift) / 2;
> guint8 green = ((pixel & ftile->visual->green_mask) >>
> ftile->visual->green_shift) / 2;
> guint8 blue = ((pixel & ftile->visual->blue_mask) >>
> ftile->visual->blue_shift) / 2;
> 
> to produce the new red, green, and blue components is both simpler and 
> works on both 16 and 24-bit displays.

Yes, it is looking strange here, too (24bit colors). I tested HEAD 1 week
ago and it was looking very good.

Christian

-- 
Christian Knoke            * * *            http://cknoke.de
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.