[Freeciv-Dev] Re: (PR#11683) ships causing unhappyness bugs

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11683 >

Christian Knoke wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=11683 >
> 
> 
> Merry Christmas to you all!
> 
> CVS 25 DEC 2004 S2 GTK2
> 
> - The computation of unhappyness seems wrong sometimes.
> 
> - It seems to be signalled too late.
> 
> I cannot exactly reproduce, but see the savegame:
> 
> Look at Osaka: no unhappyness. Then move destroyer currently in Moisakula.
> 1 step SW gives 2 unhappy in Osaka. 1 more step SW gives 4 unhappy in Osaka.
> Note that women's lib wonder is present in Saitama.

So you can reproduce it, eh?  That behavior is really bizarre.  I think 
probably while the unit is sitting in the allied city you get no 
unhappiness, and when you move it out you get unhappiness from that 
unit.  However it is clearly a bug that moving the unit a second step 
causes more unhappiness.  Note that if you move it two steps, then one 
step back, the extra unhappiness remains.

> BTW: How is the rule 'outside national borders cause unhappyness' related
> to *allied* nations borders?

Looks like allied cities are safe but I don't think allied borders are.

> PS: CMA works mostly ok now regarding unhappy change and release CMA, but
> there are still some rare cases where it does not.

As always, if you can reproduce it we can hopefully fix it.

-jason