[Freeciv-Dev] Re: (PR#11665) Technology Bug

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11665 >

On Thu, 23 Dec 2004, Jason Short wrote:

> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=11665 >
>
> Michael Mielke wrote:
> > <URL: http://bugs.freeciv.org/Ticket/Display.html?id=11665 >
> >
> > Game: Learned Ceremonial Burial.  Our scientists focus on Ceremonial
> > Burial, goal is Ceremonial Burial.
>
> Supposedly this happens in beta5 but didn't happen in beta3.  The
> get_tech_name change would be the first culprit to look at.  The lines
> causing this message were changed:
>
> -                      advances[tech_found].name,
> -                      advances[plr->research.researching].name,
> -                      advances[plr->ai.tech_goal].name);
> +                      get_tech_name(plr, tech_found),
> +                      get_tech_name(plr, plr->research.researching),
> +                      get_tech_name(plr, plr->ai.tech_goal));
>
> but I see no conceivable way this could cause the reported problem.

Well, I can. get_tech_name() returns a *static* buffer. You run it three
times, then the concatenation of the same static buffer is done 3x.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa