Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2004:
[Freeciv-Dev] Re: (PR#6933) Don't skip the iterate_end macros

[Freeciv-Dev] Re: (PR#6933) Don't skip the iterate_end macros

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: i-freeciv-lists@xxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#6933) Don't skip the iterate_end macros
From: "email_address=jdorje@xxxxxxxxxxx" <email_address=jdorje@xxxxxxxxxxx>
Date: Sat, 18 Dec 2004 14:53:36 -0800
Reply-to: bugs@xxxxxxxxxxx

<URL: >

> <URL: >
> Raimar Falke wrote:
>> If the body of the iterate however contains a goto or return statement
>> the _iterate_end macro isn't executed and the counter is wrong. The
>> idea here is to forbid such behavior.
>> The attached script tries to find such places. Run it like
>>  $ find . -name "*.c" | xargs -n 1 python
>   This script looks like a good candidate for 'make src-check'.
>   Sadly, it finds more problems than it did a year ago:
> bash-2.05b$ find freeciv -name "*.c" | xargs -n 1 python
> patches/ | wc -l
>      125

I kindof thought we'd given up on that idea.  Per's recent genlist patches
have used garbage collection instead.


[Prev in Thread] Current Thread [Next in Thread]