Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2004:
[Freeciv-Dev] Re: (PR#11338) [Patch] can_unit_transport()
Home

[Freeciv-Dev] Re: (PR#11338) [Patch] can_unit_transport()

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: marko.lindqvist@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#11338) [Patch] can_unit_transport()
From: "Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>
Date: Thu, 16 Dec 2004 19:21:44 -0800
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11338 >

On Thu, 16 Dec 2004, Marko Lindqvist wrote:

>
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=11338 >
>
> >
> >>  Function names are probably not final. What naming convention should
> >>be used here?
> >
> > It should mention "unit" somewhere.  Maybe can_unit_transport() or
> > can_unit_transport_unit() or unit_can_transport_unit().  And the same for
> > unittype.
>
>   can_unittype_transport_unittype() seemed too long so I use
> can_unit[type]_transport().
>
>
>   - Updated against latest CVS
>   - Unrelated stuff removed
>   - can_unittype_transport() made static, for now (there probably will
> be callers outside movement.c in the future)

This patch isn't in the One True Bracing style. Please indent according to
CodingStyle.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa







[Prev in Thread] Current Thread [Next in Thread]