[Freeciv-Dev] Re: (PR#11537) missing potfiles

["Christian Knoke" <chrisk@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11537 >

On Wed, Dec 15, 2004 at 04:35:14PM -0800, Genevieve Gracian wrote:
> On Wed, 15 Dec 2004 12:05:18 -0800
> "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx> wrote:

> > effects.c has at least one translatable string.

> also
> client/gui-win32/cma_fe.c 
> client/mapview_common.c  - one log error (path > 99 turn)
> client/repodlgs_common.c - messages: sell improvments, disband units
> utility/fciconv.c - one log error (text conversion)

This script gives me a list of 334 files with translatable strings (compared
to 302 in POTFILES.in):

find ./ -regex ".*\.[chprit][a-z]*$" -exec egrep -H -n    '_\("' {} \; \
| cut -f 1 -d : | cut -c 3- | sort -u > ~/potfiles

See attached file 'potfiles'.

I ignored those with sdl or ftwl in the pathname and came up with the
following changes:

+common/effects.c
+utility/fciconv.c
+utility/inputfile.c
-utility/mem.c
+utility/registry.c
+client/mapview_common.c
+client/repodlgs_common.c
-client/gui-gtk-2.0/inputdlg.c
+client/gui-stub/chatline.c
+client/gui-stub/connectdlg.c
+client/gui-stub/mapview.c
+client/gui-win32/cma_fe.c
-client/gui-xaw/colors.c
-client/gui-xaw/messagewin.c
+manual/civmanual.c
+data/themes/morgan/640x480/mapview.prop

See attached diff 'potfiles.diff'

But there is a file POTFILES.skip with the following content:

client/gui-stub/chatline.c
client/gui-stub/connectdlg.c
client/gui-stub/dialogs.c
client/gui-stub/mapview.c

I don't see why these files are there. Should the list be emptied, enhenced
or just stay?

After I applied the changes (keep POTFILES.skip), I end up with

$ msgfmt -c --statistics -v de.pox
3662 translated messages, 21 fuzzy translations, 27 untranslated messages.

Christian

-- 
Christian Knoke            * * *            http://cknoke.de
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.

ai/advdiplomacy.c
ai/aicity.c
client/agents/cma_core.c
client/agents/cma_fec.c
client/attribute.c
client/audio.c
client/audio_esd.c
client/citydlg_common.c
client/cityrepdata.c
client/civclient.c
client/climisc.c
client/clinet.c
client/connectdlg_common.c
client/control.c
client/gui-ftwl/chatline.c
client/gui-ftwl/connectdlg.c
client/gui-ftwl/dialogs.c
client/gui-ftwl/gui_main.c
client/gui-ftwl/gui_text.c
client/gui-ftwl/mapview.c
client/gui-gtk-2.0/chatline.c
client/gui-gtk-2.0/citydlg.c
client/gui-gtk-2.0/cityrep.c
client/gui-gtk-2.0/cma_fe.c
client/gui-gtk-2.0/connectdlg.c
client/gui-gtk-2.0/dialogs.c
client/gui-gtk-2.0/diplodlg.c
client/gui-gtk-2.0/finddlg.c
client/gui-gtk-2.0/gamedlgs.c
client/gui-gtk-2.0/gotodlg.c
client/gui-gtk-2.0/gui_main.c
client/gui-gtk-2.0/gui_stuff.c
client/gui-gtk-2.0/happiness.c
client/gui-gtk-2.0/helpdlg.c
client/gui-gtk-2.0/inteldlg.c
client/gui-gtk-2.0/mapctrl.c
client/gui-gtk-2.0/mapview.c
client/gui-gtk-2.0/menu.c
client/gui-gtk-2.0/messagedlg.c
client/gui-gtk-2.0/messagewin.c
client/gui-gtk-2.0/pages.c
client/gui-gtk-2.0/plrdlg.c
client/gui-gtk-2.0/repodlgs.c
client/gui-gtk-2.0/spaceshipdlg.c
client/gui-gtk-2.0/wldlg.c
client/gui-gtk/chatline.c
client/gui-gtk/citydlg.c
client/gui-gtk/cityrep.c
client/gui-gtk/cma_fe.c
client/gui-gtk/connectdlg.c
client/gui-gtk/dialogs.c
client/gui-gtk/diplodlg.c
client/gui-gtk/finddlg.c
client/gui-gtk/gamedlgs.c
client/gui-gtk/gotodlg.c
client/gui-gtk/gui_main.c
client/gui-gtk/happiness.c
client/gui-gtk/helpdlg.c
client/gui-gtk/inputdlg.c
client/gui-gtk/inteldlg.c
client/gui-gtk/mapctrl.c
client/gui-gtk/mapview.c
client/gui-gtk/menu.c
client/gui-gtk/messagedlg.c
client/gui-gtk/messagewin.c
client/gui-gtk/plrdlg.c
client/gui-gtk/repodlgs.c
client/gui-gtk/spaceshipdlg.c
client/gui-gtk/wldlg.c
client/gui-mui/chatline.c
client/gui-mui/citydlg.c
client/gui-mui/cityrep.c
client/gui-mui/connectdlg.c
client/gui-mui/dialogs.c
client/gui-mui/diplodlg.c
client/gui-mui/finddlg.c
client/gui-mui/gamedlgs.c
client/gui-mui/gotodlg.c
client/gui-mui/graphics.c
client/gui-mui/gui_main.c
client/gui-mui/helpdlg.c
client/gui-mui/inputdlg.c
client/gui-mui/inteldlg.c
client/gui-mui/mapclass.c
client/gui-mui/mapctrl.c
client/gui-mui/mapview.c
client/gui-mui/messagedlg.c
client/gui-mui/messagewin.c
client/gui-mui/plrdlg.c
client/gui-mui/repodlgs.c
client/gui-mui/spaceshipdlg.c
client/gui-mui/wldlg.c
client/gui-mui/worklistclass.c
client/gui-sdl/chatline.c
client/gui-sdl/citydlg.c
client/gui-sdl/cityrep.c
client/gui-sdl/cma_fe.c
client/gui-sdl/connectdlg.c
client/gui-sdl/dialogs.c
client/gui-sdl/diplodlg.c
client/gui-sdl/finddlg.c
client/gui-sdl/gotodlg.c
client/gui-sdl/graphics.c
client/gui-sdl/gui_main.c
client/gui-sdl/gui_string.c
client/gui-sdl/helpdlg.c
client/gui-sdl/inteldlg.c
client/gui-sdl/mapctrl.c
client/gui-sdl/mapview.c
client/gui-sdl/menu.c
client/gui-sdl/messagewin.c
client/gui-sdl/optiondlg.c
client/gui-sdl/plrdlg.c
client/gui-sdl/repodlgs.c
client/gui-sdl/spaceshipdlg.c
client/gui-sdl/wldlg.c
client/gui-stub/chatline.c
client/gui-stub/connectdlg.c
client/gui-stub/mapview.c
client/gui-win32/chatline.c
client/gui-win32/citydlg.c
client/gui-win32/cityrep.c
client/gui-win32/cma_fe.c
client/gui-win32/connectdlg.c
client/gui-win32/dialogs.c
client/gui-win32/diplodlg.c
client/gui-win32/finddlg.c
client/gui-win32/gotodlg.c
client/gui-win32/gui_main.c
client/gui-win32/happiness.c
client/gui-win32/helpdlg.c
client/gui-win32/inputdlg.c
client/gui-win32/inteldlg.c
client/gui-win32/mapctrl.c
client/gui-win32/mapview.c
client/gui-win32/menu.c
client/gui-win32/messagedlg.c
client/gui-win32/messagewin.c
client/gui-win32/optiondlg.c
client/gui-win32/plrdlg.c
client/gui-win32/ratesdlg.c
client/gui-win32/repodlgs.c
client/gui-win32/spaceshipdlg.c
client/gui-win32/wldlg.c
client/gui-xaw/chatline.c
client/gui-xaw/citydlg.c
client/gui-xaw/cityrep.c
client/gui-xaw/cma_fe.c
client/gui-xaw/connectdlg.c
client/gui-xaw/dialogs.c
client/gui-xaw/diplodlg.c
client/gui-xaw/graphics.c
client/gui-xaw/gui_main.c
client/gui-xaw/helpdlg.c
client/gui-xaw/inputdlg.c
client/gui-xaw/inteldlg.c
client/gui-xaw/mapctrl.c
client/gui-xaw/mapview.c
client/gui-xaw/menu.c
client/gui-xaw/messagedlg.c
client/gui-xaw/optiondlg.c
client/gui-xaw/plrdlg.c
client/gui-xaw/ratesdlg.c
client/gui-xaw/repodlgs.c
client/gui-xaw/wldlg.c
client/helpdata.c
client/mapctrl_common.c
client/mapview_common.c
client/messagewin_common.c
client/options.c
client/packhand.c
client/plrdlg_common.c
client/repodlgs_common.c
client/text.c
client/tilespec.c
common/aicore/cm.c
common/city.c
common/connection.c
common/effects.c
common/map.c
common/packets.c
common/player.c
common/tech.c
common/unit.c
common/unittype.c
common/version.c
data/civ1/buildings.ruleset
data/civ1/governments.ruleset
data/civ1/techs.ruleset
data/civ1/terrain.ruleset
data/civ1/units.ruleset
data/civ2/buildings.ruleset
data/civ2/governments.ruleset
data/civ2/techs.ruleset
data/civ2/terrain.ruleset
data/civ2/units.ruleset
data/default/buildings.ruleset
data/default/cities.ruleset
data/default/governments.ruleset
data/default/techs.ruleset
data/default/terrain.ruleset
data/default/units.ruleset
data/Freeciv.in
data/helpdata.txt
data/history/buildings.ruleset
data/history/governments.ruleset
data/history/techs.ruleset
data/history/terrain.ruleset
data/history/units.ruleset
data/nation/afghani.ruleset
data/nation/american.ruleset
data/nation/arab.ruleset
data/nation/argentine.ruleset
data/nation/assyrian.ruleset
data/nation/australian.ruleset
data/nation/austrian.ruleset
data/nation/aztec.ruleset
data/nation/babylonian.ruleset
data/nation/barbarian.ruleset
data/nation/bavarian.ruleset
data/nation/belgian.ruleset
data/nation/boer.ruleset
data/nation/bosnia.ruleset
data/nation/brazilian.ruleset
data/nation/canadian.ruleset
data/nation/carthaginian.ruleset
data/nation/catalan.ruleset
data/nation/chilean.ruleset
data/nation/chinese.ruleset
data/nation/columbian.ruleset
data/nation/cornish.ruleset
data/nation/croatian.ruleset
data/nation/czech.ruleset
data/nation/danish.ruleset
data/nation/dunedain.ruleset
data/nation/dutch.ruleset
data/nation/egyptian.ruleset
data/nation/elvish.ruleset
data/nation/english.ruleset
data/nation/estonian.ruleset
data/nation/ethiopian.ruleset
data/nation/filipino.ruleset
data/nation/finnish.ruleset
data/nation/french.ruleset
data/nation/galician.ruleset
data/nation/german.ruleset
data/nation/greek.ruleset
data/nation/hobbits.ruleset
data/nation/hungarian.ruleset
data/nation/icelandic.ruleset
data/nation/inca.ruleset
data/nation/indian.ruleset
data/nation/indonesian.ruleset
data/nation/irish.ruleset
data/nation/israeli.ruleset
data/nation/italian.ruleset
data/nation/japanese.ruleset
data/nation/kampuchean.ruleset
data/nation/kenyan.ruleset
data/nation/korean.ruleset
data/nation/latvian.ruleset
data/nation/lithuanian.ruleset
data/nation/malaysian.ruleset
data/nation/martian.ruleset
data/nation/mexican.ruleset
data/nation/mongol.ruleset
data/nation/mordor.ruleset
data/nation/nigerian.ruleset
data/nation/observer.ruleset
data/nation/persian.ruleset
data/nation/phoenician.ruleset
data/nation/polish.ruleset
data/nation/portuguese.ruleset
data/nation/quebecois.ruleset
data/nation/roman.ruleset
data/nation/russian.ruleset
data/nation/scottish.ruleset
data/nation/serbian.ruleset
data/nation/silesian.ruleset
data/nation/singaporean.ruleset
data/nation/sioux.ruleset
data/nation/slovenian.ruleset
data/nation/spanish.ruleset
data/nation/sumerian.ruleset
data/nation/swedish.ruleset
data/nation/swiss.ruleset
data/nation/taiwanese.ruleset
data/nation/thai.ruleset
data/nation/turk.ruleset
data/nation/ukrainian.ruleset
data/nation/vietnamese.ruleset
data/nation/viking.ruleset
data/nation/welsh.ruleset
data/nation/zulu.ruleset
data/themes/morgan/640x480/mapview.prop
manual/civmanual.c
server/autoattack.c
server/barbarian.c
server/cityhand.c
server/citytools.c
server/cityturn.c
server/civserver.c
server/commands.c
server/connecthand.c
server/console.c
server/diplhand.c
server/diplomats.c
server/gamehand.c
server/gamelog.c
server/generator/mapgen.c
server/generator/startpos.c
server/handchat.c
server/maphand.c
server/meta.c
server/plrhand.c
server/report.c
server/ruleset.c
server/savegame.c
server/sernet.c
server/settings.c
server/spacerace.c
server/srv_main.c
server/stdinhand.c
server/unithand.c
server/unittools.c
utility/fciconv.c
utility/ftwl/be_common_24_sprite.c
utility/ftwl/be_sdl.c
utility/ftwl/theme_engine.c
utility/inputfile.c
utility/log.c
utility/registry.c
utility/shared.c
utility/support.c

--- po/POTFILES.in.orig 2004-12-16 12:24:22.000000000 +0100
+++ po/POTFILES.in      2004-12-16 12:31:01.000000000 +0100
@@ -2,6 +2,7 @@
 # (Filenames relative to top-level directory.)
 common/city.c
 common/connection.c
+common/effects.c
 common/map.c
 common/packets.c
 common/player.c
@@ -10,8 +11,10 @@
 common/unittype.c
 common/version.c
 common/aicore/cm.c
+utility/fciconv.c
+utility/inputfile.c
 utility/log.c
-utility/mem.c
+utility/registry.c
 utility/shared.c
 utility/support.c
 ai/aicity.c
@@ -57,10 +60,12 @@
 client/control.c
 client/helpdata.c
 client/mapctrl_common.c
+client/mapview_common.c
 client/messagewin_common.c
 client/options.c
 client/packhand.c
 client/plrdlg_common.c
+client/repodlgs_common.c
 client/text.c
 client/tilespec.c
 client/agents/cma_core.c
@@ -79,7 +84,6 @@
 client/gui-gtk-2.0/gui_stuff.c
 client/gui-gtk-2.0/happiness.c
 client/gui-gtk-2.0/helpdlg.c
-client/gui-gtk-2.0/inputdlg.c
 client/gui-gtk-2.0/inteldlg.c
 client/gui-gtk-2.0/mapctrl.c
 client/gui-gtk-2.0/mapview.c
@@ -139,9 +143,13 @@
 client/gui-mui/spaceshipdlg.c
 client/gui-mui/wldlg.c
 client/gui-mui/worklistclass.c
+client/gui-stub/chatline.c
+client/gui-stub/connectdlg.c
+client/gui-stub/mapview.c
 client/gui-win32/chatline.c
 client/gui-win32/citydlg.c
 client/gui-win32/cityrep.c
+client/gui-win32/cma_fe.c
 client/gui-win32/connectdlg.c
 client/gui-win32/dialogs.c
 client/gui-win32/diplodlg.c
@@ -167,7 +175,6 @@
 client/gui-xaw/citydlg.c
 client/gui-xaw/cityrep.c
 client/gui-xaw/cma_fe.c
-client/gui-xaw/colors.c
 client/gui-xaw/connectdlg.c
 client/gui-xaw/dialogs.c
 client/gui-xaw/diplodlg.c
@@ -180,12 +187,12 @@
 client/gui-xaw/mapview.c
 client/gui-xaw/menu.c
 client/gui-xaw/messagedlg.c
-client/gui-xaw/messagewin.c
 client/gui-xaw/optiondlg.c
 client/gui-xaw/plrdlg.c
 client/gui-xaw/ratesdlg.c
 client/gui-xaw/repodlgs.c
 client/gui-xaw/wldlg.c
+manual/civmanual.c
 data/Freeciv.in
 data/helpdata.txt
 data/default/buildings.ruleset
@@ -294,3 +301,4 @@
 data/nation/viking.ruleset
 data/nation/welsh.ruleset
 data/nation/zulu.ruleset
+data/themes/morgan/640x480/mapview.prop