[Freeciv-Dev] Re: (PR#11545) pubserver crash in handle_authentication_reply

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11545 >

a snippet from the server log: (addresses I've culled)

Game saved as civgame-1800.sav.gz
>
2: Connection request from kmyers from  <....>
2: c4 has client version 2.0.0-beta5
>
Game saved as civgame-1750.sav.gz
>
2: kmyers has connected from  <....>

the connection struct for kmyers:

p *pconn
$13 = {id = 4, sock = 7, used = true, established = true, player = 0x0,
observer = false, buffer = 0x8403020, send_buffer = 0x84026b0, last_write =
1103182593, 
  ping_time = 0.029037, self = {list = {nelements = 1, head_link =
0x82a67f8, tail_link = 0x82a67f8}}, username = "kmyers", '\0' <repeats 25
times>, 
  addr = "<.....>", '\0' <repeats 215
times>, capability = "+2.0 conn_ping_info username_info new_hack", '\0'
<repeats 469 times>, 
  access_level = ALLOW_INFO, delayed_disconnect = false,
notify_of_writable_data = 0, client = {last_request_id_used = 0,
last_processed_request_id_seen = 0, 
    request_id_of_currently_handled_packet = 0}, server =
{currently_processed_request_id = 4, last_request_id_seen = 4, ping_timers
= 0x8402280, authentication_tries = 0, 
    authentication_stop = 0, status = AS_REQUESTING_NEW_PASS, password =
'\0' <repeats 511 times>}, incoming_packet_notify = 0,
outgoing_packet_notify = 0, phs = {
    sent = 0x83e4f90, received = 0x83e5180, variant = 0x83e5370},
compression = {frozen_level = 1, queue = {p = 0x83be168 "", size = 523,
size_alloc = 804}}, statistics = {
    bytes_send = 69}}

This actually shows diddly. The core is almost a complete waste of time. I 
chatted with kmyers about what happened. The order of events seems to be:
connection was accepted and establish_new_connection() was called just
fine. In fact it seems that it made it all the way through that function...

(gdb) p game.all_connections 
$14 = {list = {nelements = 2, head_link = 0x82cde70, tail_link = 0x82bda30}}
(gdb) p game.est_connections
$15 = {list = {nelements = 2, head_link = 0x838e018, tail_link = 0x82c8740}}
(gdb) p game.game_connections
$16 = {list = {nelements = 1, head_link = 0x8414c98, tail_link = 0x8414c98}}

I don't think the fact that kmyers was a new user to the database had
anything to do with it.

I tried to reproduce the crash but could not. I'm wondering if we should
start compiling servers with -O0 until release.

-mike