Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2004:
[Freeciv-Dev] Re: (PR#11535) when researching tech first, you get two ga
Home

[Freeciv-Dev] Re: (PR#11535) when researching tech first, you get two ga

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#11535) when researching tech first, you get two gamelogs
From: "Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 15 Dec 2004 11:47:21 -0800
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11535 >

On Wed, Dec 15, 2004 at 11:10:24AM -0800, Jason Short wrote:
> 
> Paul points out that when you research a tech for the first time you get 
> two identical gamelogs.  One is called in tech_researched and another in 
> found_new_tech.  The found_new_tech one is only called if you're the 
> first to research it.  This used to work fine but now the log is 
> identical so it isn't useful.
> 
> This patch fixes it simply by removing it.  Any program looking at the 
> gamelog should be able to figure out who was first just by scanning the 
> gamelog.  It's also possible to fix the log but I don't know how to do that.

The first question I would have is: do we care about having an entry for if
a this discovery was the first? If we do, add a tag <f>0|1</f> whether the
tech was first or not to GAMELOG_TECH In the switch statement, you'd have
to do a tech iterate and see if this player is the only one to have the
tech and then set <f> accordingly.

-mike





[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] Re: (PR#11535) when researching tech first, you get two gamelogs, Mike Kaufman <=