Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2004:
[Freeciv-Dev] (PR#11535) when researching tech first, you get two gamelo

[Freeciv-Dev] (PR#11535) when researching tech first, you get two gamelo

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] (PR#11535) when researching tech first, you get two gamelogs
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 15 Dec 2004 11:10:24 -0800
Reply-to: bugs@xxxxxxxxxxx

<URL: >

Paul points out that when you research a tech for the first time you get 
two identical gamelogs.  One is called in tech_researched and another in 
found_new_tech.  The found_new_tech one is only called if you're the 
first to research it.  This used to work fine but now the log is 
identical so it isn't useful.

This patch fixes it simply by removing it.  Any program looking at the 
gamelog should be able to figure out who was first just by scanning the 
gamelog.  It's also possible to fix the log but I don't know how to do that.


Index: server/plrhand.c
RCS file: /home/freeciv/CVS/freeciv/server/plrhand.c,v
retrieving revision 1.344
diff -u -r1.344 plrhand.c
--- server/plrhand.c    15 Dec 2004 03:59:21 -0000      1.344
+++ server/plrhand.c    15 Dec 2004 19:08:00 -0000
@@ -288,8 +288,8 @@
   was_first = (game.global_advances[tech_found] == 0);
   if (was_first) {
-    gamelog(GAMELOG_TECH, plr, NULL, tech_found);
+    /* We used to have a gamelog() for first-researched, but not anymore. */
     /* Alert the owners of any wonders that have been made obsolete */
     impr_type_iterate(id) {
       if (game.global_wonders[id] != 0 && is_wonder(id) &&

[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] (PR#11535) when researching tech first, you get two gamelogs, Jason Short <=