[Freeciv-Dev] (PR#11418) loading saved games causes a crash in 2.0

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11418 >

(gdb) p advances[26].name
$1 = 0x8279e14 "Environmentalism"

The assertion here is definitely overzealous.  Techs that don't exist 
exist and have names.  Probably we shouldn't be loading a sprite for a 
nonexistant tech.  Probably we shouldn't have nonexistant techs at all. 
  But for 2.0 at least this assertion should be removed.

-jason

Index: common/tech.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/common/tech.c,v
retrieving revision 1.76.2.1
diff -u -r1.76.2.1 tech.c
--- common/tech.c       8 Dec 2004 20:48:35 -0000       1.76.2.1
+++ common/tech.c       9 Dec 2004 01:34:04 -0000
@@ -590,7 +590,6 @@
   default:
     /* Includes A_NONE */
     if (!tech_exists(tech)) {
-      assert(0);
       my_snprintf(buffer, sizeof(buffer), _("(Unknown)"));
     } else {
       my_snprintf(buffer, sizeof(buffer), "%s", advances[tech].name);