Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2004:
[Freeciv-Dev] Re: (PR#11350) handle_city_short_info Does not use create_ 		Home

[Freeciv-Dev] Re: (PR#11350) handle_city_short_info Does not use create_

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: badamson@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#11350) handle_city_short_info Does not use create_city_virtual.
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 7 Dec 2004 15:52:06 -0800
Reply-to: rt@xxxxxxxxxxx 
<URL: http://rt.freeciv.org/Ticket/Display.html?id=11350 >

Benedict Adamson wrote:

> +
> +    pcity->owner=packet->owner;
> +    sz_strlcpy(pcity->name, packet->name);
>      
>      assert(pcity->id == packet->id);
>    }
> -
> -  pcity->owner=packet->owner;
> -  pcity->tile = map_pos_to_tile(packet->x, packet->y);
> -  sz_strlcpy(pcity->name, packet->name);

This looks wrong.  Cities can change owners you know.

-jason
[Prev in Thread] Current Thread [Next in Thread]