Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2004:
[Freeciv-Dev] Re: (PR#11350) handle_city_short_info Does not use create_
Home

[Freeciv-Dev] Re: (PR#11350) handle_city_short_info Does not use create_

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: badamson@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#11350) handle_city_short_info Does not use create_city_virtual.
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 5 Dec 2004 10:59:01 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=11350 >

Benedict Adamson wrote:

> However, it seems to me that handle_city_short_info should also create 
> new cities using create_city_virtual. I suspect some of the code for 
> setting default values could then be removed. More importantly, it 
> prevents bugs when fields, such as unit_lists, are added to 'struct 
> city' that should be cleanly removed (to prevent memory leaks) but must 
> also be initialised.

Absolutely.  Will you make a patch?

-jason





[Prev in Thread] Current Thread [Next in Thread]