[Freeciv-Dev] (PR#11350) handle_city_short_info Does not use create_city_virtual.

["Benedict Adamson" <badamson@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=11350 >

The client creates and registers city structures in two places:
handle_city_info creates a new city using create_city_virtual; 
handle_city_short_info uses a simple fc_malloc. The function 
remove_city_virtual is always used to destroy these city structures.

However, it seems to me that handle_city_short_info should also create 
new cities using create_city_virtual. I suspect some of the code for 
setting default values could then be removed. More importantly, it 
prevents bugs when fields, such as unit_lists, are added to 'struct 
city' that should be cleanly removed (to prevent memory leaks) but must 
also be initialised.