Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2004:
[Freeciv-Dev] (PR#11313) utility/fcintl.h conflicts with libintl.h
Home

[Freeciv-Dev] (PR#11313) utility/fcintl.h conflicts with libintl.h

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: fbriere@xxxxxxxxxxx
Subject: [Freeciv-Dev] (PR#11313) utility/fcintl.h conflicts with libintl.h
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 4 Dec 2004 02:12:55 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=11313 >

> [fbriere@xxxxxxxxxxx - Fri Dec 03 03:55:55 2004]:
> 
> utility/fcintl.h defines some replacement functions for libintl.h if
> ENABLE_NLS is false; this will result in a compilation error if
> libintl.h is included afterwards.  (For example, <strings> includes it
> indirectly.)
> 
> This patch adds a check for libintl.h in configure.ac, and forces the
> inclusion of libintl.h (if present) before redefining its functions in
> utility/fcintl.h.

OK.

> I've also modified intl/libgettext.h in the same way, even though this
> file appears to be unused at the moment.

I don't think that's right.  This file is part of the "included"
gettext, which is very old and should be either upgraded or removed (but
not changed).

-jason




[Prev in Thread] Current Thread [Next in Thread]