[Freeciv-Dev] (PR#11245) sanity_check_city on an unrefreshed city

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=11245 >

I believe it is possible for sanity_check_city to be called on an 
unrefreshed city - a city that has been created (via 
create_city_virtual) but has never had its "other" fields set via 
generic_city_refresh.

In the current code this causes no problems since all checked fields are 
set in generic_city_refresh.  However one of the purposes of sanity 
checking should be to make sure the city is up-to-date.  So this should 
be fixed.

jason