[Freeciv-Dev] (PR#11174) client segfaults w/o map_canvas_resized()
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
<URL: http://rt.freeciv.org/Ticket/Display.html?id=11174 >
> [fbriere@xxxxxxxxxxx - Wed Nov 24 04:34:17 2004]:
>
> Hi! I'm working on a new client, and was bitten by a subtle bug: it
> seems that client/mapview_common.c never bothers to initialize
> mapview_canvas, but instead relies on the client to call
> map_canvas_resized() when the canvas is created. Since I'm not to the
> point where I can display a map yet, I had to stick a dummy call to
> prevent a segfault.
>
> It seems to me that mapview_common should either initialize
> mapview_canvas early on, or better yet, skip any rendering on it until
> the client has initialized it via map_canvas_resized().
init_mapcanvas_and_overview() would be a good candidate for this I
think. Or we could just skip the drawing, as you say. Either way, will
you make a patch?
-jason
|
|