[Freeciv-Dev] Re: (PR#11130) city destruction message missing

["Christian Knoke" <chrisk@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=11130 >

On Mon, Nov 22, 2004 at 03:00:52PM -0800, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=11130 >
> 
> > [chrisk - Sun Nov 21 15:16:43 2004]:
> 
> > When a military unit destroys an empty enemy city, no message is given
> (only
> > a chat message).
> 
> 
>     notify_player_ex(pplayer, pcity->tile, E_NOEVENT,
>                    _("Game: You destroy %s completely."), pcity->name);
>     notify_player_ex(cplayer, pcity->tile, E_CITY_LOST, 
>                    _("Game: %s has been destroyed by %s."), 
>                    pcity->name, pplayer->name);
> 
> So there is an E_CITY_LOST message for the player who loses the city and
> an E_NOEVENT message for the player who destroys the city.
> 
> In most cases the E_NOEVENT message will only be shown on the chatline.
>  Should we change this to E_CITY_LOST also?  This isn't quite right but
> probably better.  For 2.0 adding a new event type is probably too much.

I'd suggest E_UNIT_WIN_ATT for the first message.

I attack someone and want to see the result.

Christian

-- 
Christian Knoke            * * *            http://cknoke.de
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.