Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2004:
[Freeciv-Dev] (PR#11134) Small fixes in i18n and help
Home

[Freeciv-Dev] (PR#11134) Small fixes in i18n and help

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: chrisk@xxxxxxxxx
Subject: [Freeciv-Dev] (PR#11134) Small fixes in i18n and help
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 22 Nov 2004 13:41:06 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=11134 >

> [chrisk - Mon Nov 22 18:56:30 2004]:
> 
> On Mon, Nov 22, 2004 at 10:45:44AM -0800, Christian Knoke wrote:
> >
> > Without the mentioned fix this does not work. The string ?key:space
> is now
> > in de.po, but the client code cannot handle the translation. So the
> key name
> > in the Orders menue is just empty now. This should be fixed.
> 
> Even worse, the space key stopped working :-(

So this needs to be reverted?  Does this patch do it?

-jason

Index: client/gui-gtk/menu.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk/menu.c,v
retrieving revision 1.94
diff -u -r1.94 menu.c
--- client/gui-gtk/menu.c       22 Nov 2004 07:54:46 -0000      1.94
+++ client/gui-gtk/menu.c       22 Nov 2004 20:02:47 -0000
@@ -756,7 +756,7 @@
        NULL,                   0,                                      
"<Separator>"   },
   { "/" N_("_Orders") "/" N_("_Wait"),                 "w",
        orders_menu_callback,   MENU_ORDER_WAIT                                 
        },
-  { "/" N_("_Orders") "/" N_("Done"),                  N_("?key:space"),
+  { "/" N_("_Orders") "/" N_("Done"),                  "space",
        orders_menu_callback,   MENU_ORDER_DONE                                 
        },
   /* Reports menu ... */
   { "/" N_("_Reports"),                                        NULL,
Index: client/gui-gtk-2.0/menu.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk-2.0/menu.c,v
retrieving revision 1.55
diff -u -r1.55 menu.c
--- client/gui-gtk-2.0/menu.c   22 Nov 2004 07:54:46 -0000      1.55
+++ client/gui-gtk-2.0/menu.c   22 Nov 2004 20:02:47 -0000
@@ -807,7 +807,7 @@
        NULL,                   0,                                      
"<Separator>"   },
   { "/" N_("Orders") "/" N_("_Wait"),                  "w",
        orders_menu_callback,   MENU_ORDER_WAIT                                 
        },
-  { "/" N_("Orders") "/" N_("Done"),                   N_("?key:space"),
+  { "/" N_("Orders") "/" N_("Done"),                   "space",
        orders_menu_callback,   MENU_ORDER_DONE                                 
        },
   /* Reports menu ... */
   { "/" N_("_Reports"),                                        NULL,

[Prev in Thread] Current Thread [Next in Thread]