Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2004:
[Freeciv-Dev] Re: (PR#9310) startunits
Home

[Freeciv-Dev] Re: (PR#9310) startunits

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: ggracian@xxxxxxx
Subject: [Freeciv-Dev] Re: (PR#9310) startunits
From: "Marko Lindqvist" <marko.lindqvist@xxxxxxxxxxx>
Date: Sat, 20 Nov 2004 05:29:38 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9310 >

Marko Lindqvist wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9310 >
> 
> Genevieve Gracian wrote:
> 
>>The string for startunits is limited to 15 characters, makes 15 units
>>max but on stable version it's possible to have 20 units (10 settlers
>>and 10 explos). Is the new max number of units wanted?
> 
>   Attached patch takes care of the most critical part of this ticket; 
> savegame loading was not checking array bounds when loading old saves, 
> so loading such an old game with > 15 startunits got out of bounds.

  This memory corruption is relatively non-critical as next to 
startunits array in game struct are variables 'dispersion' & 'tech' 
which affect game only in the beginning (not after loading saved game), 
but some maintainer should at least comment latest patch in this ticket.


  - Caz





[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] Re: (PR#9310) startunits, Marko Lindqvist <=