[Freeciv-Dev] Re: (PR#10437) Another assert failure for "punit->transported_by > 0"

["Marko Lindqvist" <marko.lindqvist@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10437 >

Jason Short wrote:
> However the main bugs are still in year 1480, and with some more 
> debugging I find them.
> 
> 1.  punit->owner == ferryboat->owner == 4.  However pplayer->player_no 
> == 3.  So somehow we are trying to control a unit that we don't own.
> 
> 2.  In handle_unit_load, player_find_unit_by_id is used for both cargo 
> and transporter.  For the transporter this should just be 
> find_unit_by_id.  We are allowed to load units into transports owned by 
> someone else - according to can_unit_load the rule is that the cargo and 
> transporter's owners must be allied.
> 
> The attached patch should fix bug#2 and the symptoms of bug#1 (which is 
> probably related to the 2 other bugs above).  However a proper fix for 
> bug#1 is probably needed to avoid other problems (like trying to build 
> boats to transport enemy units...that would be bad...).
> 
> jason


  Attached autogame asserts (even/only) when this patch applied.


  - Caz

set savename  transport

set timeout   -1
normal
create Tester
set aifill    7
set saveturns 1
set endyear   1600

set gameseed  1096882709
set mapseed   548124920

start