Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2004:
[Freeciv-Dev] (PR#10950) help dialog error when changing tilesets
Home

[Freeciv-Dev] (PR#10950) help dialog error when changing tilesets

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] (PR#10950) help dialog error when changing tilesets
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 8 Nov 2004 16:55:33 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10950 >

When changing tilesets with the help dialog open on a unit, you'll get a 
crash.

The fix is to popdown all dialogs when changing tilesets.

jason

Index: client/tilespec.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/tilespec.c,v
retrieving revision 1.208
diff -u -r1.208 tilespec.c
--- client/tilespec.c   23 Oct 2004 19:10:26 -0000      1.208
+++ client/tilespec.c   9 Nov 2004 00:53:57 -0000
@@ -42,11 +42,13 @@
 #include "support.h"
 #include "unit.h"
 
+#include "dialogs_g.h"
+#include "graphics_g.h"
+#include "mapview_g.h"         /* for update_map_canvas_visible */
+
 #include "civclient.h"         /* for get_client_state() */
 #include "climap.h"            /* for tile_get_known() */
 #include "control.h"           /* for fill_xxx */
-#include "graphics_g.h"
-#include "mapview_g.h"         /* for update_map_canvas_visible */
 #include "options.h"           /* for fill_xxx */
 
 #include "tilespec.h"
@@ -491,6 +493,7 @@
        we don't want/need to redraw. */
     return;
   }
+  popdown_all_game_dialogs();
   generate_citydlg_dimensions();
   tileset_changed();
   can_slide = FALSE;

[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] (PR#10950) help dialog error when changing tilesets, Jason Short <=