[Freeciv-Dev] Re: (PR#10886) freeciv 2 beta 2: teams & ais

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10886 >

On Fri, 5 Nov 2004, Karl-Ingo Friese wrote:
> again freeciv 2.0 beta 2:
>
> When playing with humans and ais in one team, two
> unwanted things happen:
>
> a) The ai immidialtely withdraws shared vison (sv)
>   because the teampartners are "not trustworthy". If
>   the human withdraws sv as well, ais keep on requesting
>   it back without offering sv by their own.

Thanks. Obvious bug:

diff -u -r1.48 advdiplomacy.c
--- ai/advdiplomacy.c   31 Oct 2004 22:14:46 -0000      1.48
+++ ai/advdiplomacy.c   8 Nov 2004 14:53:06 -0000
@@ -137,6 +137,9 @@
 static bool shared_vision_is_safe(struct player* pplayer,
                                   struct player* aplayer)
 {
+  if (pplayer->team != TEAM_NONE && pplayer->team == aplayer->team) {
+    return TRUE;
+  }
   players_iterate(eplayer) {
     if (eplayer == pplayer || eplayer == aplayer) {
       continue;

> b) It is impossible to do research when teaming with
>   an ai, since it changes the goal every turn.
> Additionaly if several humans and several ais are in
>   one team, odd things happen. We were playing
>   two teams; 2 humans + 2 ai vs. 2 humans + 3 ai
>   Just a few examples:
>   - at several turns, the two team mates saw different
>     research in their science dialog
>   - sometimes the dialog shows 723 / 2
>   - etc,

Ouch. This will take me some more time to figure out.

  - Per