[Freeciv-Dev] (PR#10770) some bugs

["Mateusz Stefek" <mstefek@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10770 >

> [marcruhlmann@xxxxxxxxxxx - Thu Oct 28 15:12:23 2004]:
> 
> I use freeciv under windows XP.

> -When I get a new technology from the great library, I automatically
> lose
> the research points I had in the technology I'm searching, despite the
> fact
> that freecost, conquercost and diplcost are set to "0". Only
> techpenalty is
> set to 100.

If it is the same technology you are researching then this is ok
 
> - I don't know if it is a bug or if it is voluntary, but opponents can
> build
> cities inside other people's fronteers. To my mind, this shouldn't be
> possible, at least when the two nations are not allied or eventually
> in
> peace. Is it a real bug or only the chosen rules?

Actually it's a feature, not a bug :).
Changing rules isn't easy. There are some problems with diplomacy model
and probably with AI

> - I noticed too that some options aren't saved. Because I find it
> boring to
> set all the options before each game, I chose to save the game before
> its
> beginning, so that only the options are saved, and not the world. When
> I do
> this, the options "topology" and "size" automatically return to their
> original values ("0" and "4" respectively) when I reload the game in
> order
> to start a new game, as all the other otpions are still set to where I
> set
> them.

This is a bug. Attached patch should help.

> I hope thiss will help you. Congratulatoins for your work, the
> improvements
> since the last version are really excellent.
> 
> Marc
> 
thanks
--
mateusz

Index: savegame.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/savegame.c,v
retrieving revision 1.201
diff -u -r1.201 savegame.c
--- savegame.c  15 Oct 2004 21:34:24 -0000      1.201
+++ savegame.c  29 Oct 2004 11:41:27 -0000
@@ -3295,6 +3295,10 @@
                                     "game.dispersion");
       }
 
+      map.topology_id = secfile_lookup_int_default(file, MAP_ORIGINAL_TOPO,
+                                                  "map.topology_id");
+      map.size = secfile_lookup_int_default(file, MAP_DEFAULT_SIZE,
+                                            "map.size");
       map.riches = secfile_lookup_int(file, "map.riches");
       map.huts = secfile_lookup_int(file, "map.huts");
       map.generator = secfile_lookup_int(file, "map.generator");
@@ -3681,6 +3685,7 @@
      * when PRE_GAME_STATE, but I'm standardizing on width,height --dwp
      */
     secfile_insert_int(file, map.topology_id, "map.topology_id");
+    secfile_insert_int(file, map.size, "map.size");
     secfile_insert_int(file, map.xsize, "map.width");
     secfile_insert_int(file, map.ysize, "map.height");
     secfile_insert_str(file, game.start_units, "game.start_units");