[Freeciv-Dev] (PR#10626) Remove firepower

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10626 >

I want to remove firepower from the game. Why? Because almost nobody
really understands how it works, and most people overlook it. Its special
rules are better split up and made explicit as flags.

So here goes the new flags needed to emulate previous firepower rules:
 - "City_Vulnerable": Unit has half defense power when in a city.
 - "Air_Vulnerable": Unit has half defense power against air units.
 - "Ship_Buster": Unit has double attack power against ships.
 - "Ship_Defender": Unit has double defense power against ships.

For completeness, should also add:
 - "City_Defender": Unit has double defense power in a city.

These flags need changing:
 - "City_Buster": Doubles attack power instead of firepower.

Ignored:
 - When attacking land, ships and attacked unit gets firepower set to 1.
Why the second, I have no idea, since only land units that are very poor
defenders and good attackers have 2 firepower. So the second part there I
ignore.

Comments?

I also think hitpoints should be set to a fixed number. Few people who see
a frigate's 4 attack power and ironclad's 4 attack power, check the
ironclads superior hitpoints value to see that the latter is a better
attacker. But this is a separate issue.

  - Per