[Freeciv-Dev] (PR#10368) RfP: #define ACTIVITY_FACTOR

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10368 >

Oh, and also: it should be safe to change ACTIVITY_FACTOR to 1 and just
get rid of it.  However this should not be done in the stable branch.

The *10 factor for activities was added in:

date: 2004/01/11 17:45:04;  author: per;  state: Exp;  lines: +9 -9
Add support for multiple veteran levels, defined in units.ruleset. See
new documentation in units.ruleset for more info. Patch by James Blewitt
<james.blewitt@xxxxxxxxxxxxxx> Rafal Bursig <bursig@xxxxxxxxx> and me.

However there is no documentation of why it would be needed and no PR#
to look up the original discussion.  So I have no idea why it is needed.
 Per, can you shed any light on this?

The only reason I can think of is the +1 bug in 1.14 (if MP==0 the
activity rate was treated as "1").  Adding the *10 factors is a
roundabout sort of way of fixing this.

jason