Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2004:
[Freeciv-Dev] Re: (PR#10389) logging of dead explorer
Home

[Freeciv-Dev] Re: (PR#10389) logging of dead explorer

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] Re: (PR#10389) logging of dead explorer
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 29 Sep 2004 15:08:54 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10389 >

Guest wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=10389 >
> 
>>  Or maybe this unit_log should just be removed.  Reading this data is 
>>harmless but the unit_log is also useless because the data could have 
>>been changed.

> Actually, the unit data cannot have changed yet. The server is single-
> threaded, is it not? Check the call order. The unit_log is reached
> before the next malloc.

I don't think you can rely on this.  The free() itself may move 
meta-data around to overwite it.  Or a new malloc call may be added 
somewhere that overwrites the freed area.

jason




[Prev in Thread] Current Thread [Next in Thread]