Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2004:
[Freeciv-Dev] Re: (PR#10368) RfP: #define ACTIVITY_FACTOR 		Home

[Freeciv-Dev] Re: (PR#10368) RfP: #define ACTIVITY_FACTOR

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] Re: (PR#10368) RfP: #define ACTIVITY_FACTOR
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 28 Sep 2004 08:53:59 -0700
Reply-to: rt@xxxxxxxxxxx 
<URL: http://rt.freeciv.org/Ticket/Display.html?id=10368 >

Marek "Baczek" Baczyński wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=10368 >
> 
> On Mon, 27 Sep 2004 19:26:31 -0700, Jason Short
> <jdorje@xxxxxxxxxxxxxxxxxxxxx> wrote:
> 
> 
>>In map.c in map_activity_time() there is a constant value 10.  It is
>>also used by almost all callers.  It should be changed to a #define
>>ACTIVITY_FACTOR in map.h.
>>
>>Patch wanted.
> 
> Changed all 10s to ACTIVITY_FACTOR.

Ahh, but all the callers use the 10 as well.  They have to divide by it 
before they can use the final factor (or in case of comparisons, they 
may multiply the other side of the comparison by 10).  Hunting down all 
these users may be a bit of work.

jason
[Prev in Thread] Current Thread [Next in Thread]