[Freeciv-Dev] (PR#10201) PATCH: generator characteristics evolution, best handled temperature and relief.

["Mateusz Stefek" <mstefek@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10201 >

> [mburda - Wed Sep 22 15:37:10 2004]:
This i getting really messy!
1) It's quite hard to remember all places where heightmap, tmap, placed
and characteristics should be created or freed.
Could you change them to local variables?
I imagine height map as a class with one public attribute:
  int* height_map
and with methods:
hmap_init
hmap_free_data
hmap_get_shore_level
hmap_get_mountains_level
hamp_normalize_poles
hmap_renormalize_poles
hmap_make_random_hmap
hmap_make_pseudofractal1_map

The same with other maps.
2) Move functions into proper files
  For example: terrain_is_too_high should be in height_map
probably renamed hmap_terrain_is_to_high
3) Why place terrain takes 3 characteristic_types? Can not it take their
sum?
--
mateusz