Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2004:
[Freeciv-Dev] Re: (PR#9913) failed auth leaves client in inconsistent st
Home

[Freeciv-Dev] Re: (PR#9913) failed auth leaves client in inconsistent st

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: mstefek@xxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#9913) failed auth leaves client in inconsistent state
From: "Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 14 Sep 2004 21:43:28 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9913 >

here's the beginning of a fix for this problem. The server doesn't close
the connection to the client completely on a rejection of connection.

-mike

? remove_all.diff
? server/.stdinhand.c.swp
Index: server/connecthand.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/connecthand.c,v
retrieving revision 1.29
diff -u -r1.29 connecthand.c
--- server/connecthand.c        15 Sep 2004 02:29:29 -0000      1.29
+++ server/connecthand.c        15 Sep 2004 04:42:12 -0000
@@ -196,6 +196,7 @@
   send_packet_server_join_reply(pconn, &packet);
   freelog(LOG_NORMAL, _("Client rejected: %s."), conn_description(pconn));
   flush_connection_send_buffer_all(pconn);
+  close_connection(pconn);
 }
 
 /**************************************************************************

[Prev in Thread] Current Thread [Next in Thread]